Add exchange parameter to AMQP External Rule
#170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paddybyers
reviewed
Dec 13, 2023
graham-russell
force-pushed
the
feature/SDK-3336-amqpexternal-rule-exchange-param
branch
6 times, most recently
from
bd73030 to
2aaa098
Compare
owenpearson
approved these changes
Dec 14, 2023
This commit adds an `exchange` parameter to the [ably_rule_amqp_external Resource](https://registry.terraform.io/providers/ably/ably/latest/docs/resources/rule_amqp_external). The `exchange` parameter allows specifying a RabbitMQ exchange. If required, this parameter supports interpolation. See [Ably FAQ](https://faqs.ably.com/what-is-the-format-of-the-routingkey-for-an-amqp-or-kinesis-reactor-rule) for information. If RabbitMQ exchanges are not used, this parameter should not be specified in the Terraform resource. Addresses #159
Change `targetManditoryRoute` to `targetMandatoryRoute`
graham-russell
force-pushed
the
feature/SDK-3336-amqpexternal-rule-exchange-param
branch
from
2aaa098 to
8ce94d2
Compare
graham-russell
deleted the
feature/SDK-3336-amqpexternal-rule-exchange-param
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds an
exchangeparameter to the ably_rule_amqp_external Resource.The
exchangeparameter allows specifying a RabbitMQ exchange. If required, this parameter supports interpolation.See Ably FAQ for information.
If RabbitMQ exchanges are not used, this parameter should not be specified in the Terraform resource.
Addresses #159